add nf-test and fix stub happy/sompy #6285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SPPearce
reviewed
Aug 23, 2024
Comment on lines
42
to
45
| { assert snapshot(process.out.stats).match("stats_1") }, | ||
| { assert snapshot(process.out.versions).match("versions_1") }, | ||
| { assert snapshot(file(process.out.metrics[0][1]).name).match("metrics_1")}, | ||
| { assert snapshot(file(process.out.features[0][1]).name).match("features_1")} |
There was a problem hiding this comment.
Can you put all the snapshots into one: (indentation probably needs fixing)
Suggested change
| { assert snapshot(process.out.stats).match("stats_1") }, | |
| { assert snapshot(process.out.versions).match("versions_1") }, | |
| { assert snapshot(file(process.out.metrics[0][1]).name).match("metrics_1")}, | |
| { assert snapshot(file(process.out.features[0][1]).name).match("features_1")} | |
| { assert snapshot( | |
| process.out.stats, | |
| process.out.versions, | |
| file(process.out.metrics[0][1]).name, | |
| file(process.out.features[0][1]).name | |
| ).match() }, |
There was a problem hiding this comment.
when I don't separate "versions", lint gives an error. that is why I put it like this.
There was a problem hiding this comment.
Hmm, shouldn't be an issue like this, I've done it on a number of modules
There was a problem hiding this comment.
I dont know what was that, but it works out inside one match now
SPPearce
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #XXX
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda